[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

[Toolybird]

> So we need to unset CFLAGS and LDFLAGS in the configure script.

Yes, but is this what you really want? It seems to go against standard
practice. The usual expectation is even documented in Meson docs:

https://mesonbuild.com/howtox.html#set-extra-compiler-and-linker-flags-
from-the-outside-when-eg-building-distro-packages

Yes, qemu is a complex beast and I understand why you want full control
over the build. But it certainly will make life harder for downstream
distros/users who like to build pkgs with their own preferred options.

BTW, --extra-ldflags="my additional linker option" seems to work.
But --extra-cflags="my additional compiler switch" seems to also add it to the 
link line which seems a bit odd?

>From configure script:

--extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg"
                  QEMU_LDFLAGS="$QEMU_LDFLAGS $optarg"

The whole conversion to Meson is clearly a massive effort and deserves
big praise :) But as a clueless end user, I wonder why you didn't just
bite the bullet and go full Meson (à la Libvirt) and get rid of the
configure script completely?

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096

Title:
  Git version: Build process is broken in block_curl.c.o

Status in QEMU:
  Invalid

Bug description:
  Gcc version: 10.2.0
  Glusterfs: 8.1
  Libguestfs: 1.42

  Configure options used:

  configure \
      --prefix=/usr \
      --sysconfdir=/etc \
      --localstatedir=/var \
      --libexecdir=/usr/lib/qemu \
      --extra-ldflags="$LDFLAGS" \
      --smbd=/usr/bin/smbd \
      --enable-modules \
      --enable-sdl \
      --disable-werror \
      --enable-slirp=system \
      --enable-xfsctl \
      --audio-drv-list="pa alsa sdl"
      
  Error log attached. Here is the beginning:

  /usr/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../lib/Scrt1.o: 
in function `_start':
  (.text+0x24): undefined reference to `main'
  /usr/bin/ld: libblock-curl.a(block_curl.c.o): in function `curl_block_init':

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1896096/+subscriptions