[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] configure: cleanup CFLAGS and LDFLAGS for submodules
From: |
Richard Henderson |
Subject: |
Re: [PATCH 2/4] configure: cleanup CFLAGS and LDFLAGS for submodules |
Date: |
Sun, 20 Sep 2020 16:10:43 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/20/20 2:30 AM, Paolo Bonzini wrote:
> The -g and -O2 flags that configure adds to CFLAGS are only used by
> submodules,
> so do not put anymore the confusing CFLAGS variable in config-host.mak and
> replace it with more explicit SUBMODULE_CFLAGS variable.
>
> There was also no equivalent SUBMODULE_LDFLAGS variable, add it. This would
> theoretically help with LTO if we want -g and -O2 options on the command line.
> I say "theoretically" because submodules should not be linking anything; but
> since we were passing an "LD" variable we might as well get its flags right.
>
> CFLAGS are now synthesized in the configuration summary as a quick way to
> present
> --enable-debug and --enable-debug-info.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~