[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicat
|
From: |
Paul Durrant |
|
Subject: |
RE: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error |
|
Date: |
Mon, 21 Sep 2020 08:01:15 +0100 |
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On Behalf Of
> Philippe Mathieu-Daudé
> Sent: 20 September 2020 12:44
> To: Markus Armbruster <armbru@redhat.com>; qemu-devel@nongnu.org
> Cc: Laurent Vivier <laurent@vivier.eu>; Paolo Bonzini <pbonzini@redhat.com>;
> Anthony Perard
> <anthony.perard@citrix.com>; Stefano Stabellini <sstabellini@kernel.org>;
> Daniel P. Berrangé
> <berrange@redhat.com>; Eduardo Habkost <ehabkost@redhat.com>; Paul Durrant
> <paul@xen.org>; Marcel
> Apfelbaum <marcel.apfelbaum@gmail.com>; Michael S. Tsirkin <mst@redhat.com>;
> xen-
> devel@lists.xenproject.org; Philippe Mathieu-Daudé <f4bug@amsat.org>
> Subject: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to
> indicate error
>
> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize()
> with the ability to return a boolean value if an error occured,
> thus the caller does not need to check if the Error* pointer is
> set.
> Provide the same ability to the BusRealize type.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/qdev-core.h | 14 +++++++++++++-
> hw/hyperv/vmbus.c | 5 +++--
> hw/nubus/nubus-bus.c | 5 +++--
> hw/pci/pci.c | 12 +++++++++---
> hw/xen/xen-bus.c | 5 +++--
Acked-by: Paul Durrant <paul@xen.org>