[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/8] Configurable policy for handling deprecated interface
From: |
Peter Krempa |
Subject: |
Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces |
Date: |
Mon, 21 Sep 2020 14:54:15 +0200 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote:
> Some general comments on using the patch:
>
> * For libguestfs I chose to add
>
> -compat deprecated-input=reject,deprecated-output=hide
>
> This is only enabled in developer builds of libguestfs when we
> are running qemu directly (not via libvirt). The patch for
> this is attached.
>
> * What's the point/difference in having reject vs crash?
I'll be adding the following documentation for the qemu.conf entry in
libvirt controling the feature:
+# The "reject" option is less harsh towards the VMs but some code paths ignore
+# errors reported by qemu and thus it may not be obvious that a deprecated
+# command/field was used, thus it's suggested to use the "crash" option
instead.
- Re: [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces, (continued)
- [PATCH v5 8/8] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2020/09/14
- [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2020/09/14
- [PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2020/09/14
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces, Richard W.M. Jones, 2020/09/21
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces,
Peter Krempa <=
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces, Peter Maydell, 2020/09/21