Re: [PATCH 5/6] travis.yml: Update Travis to use Bionic and Focal instead of Xenial

[Cleber Rosa]

On Fri, Sep 18, 2020 at 12:34:29PM +0200, Thomas Huth wrote:
> According to our support policy, we do not support Xenial anymore.
> Time to switch the bigger parts of the builds to Focal instead.
> Some few jobs have to be updated to Bionic instead, since they are
> currently still failing on Focal otherwise. Also "--disable-pie" is
> causing linker problems with newer versions of Ubuntu ... so remove
> that switch from the jobs now (we still test it in a gitlab CI job,
> so we don't lose much test coverage here).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .travis.yml | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 1fc49b0746..80da4ebc8e 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -2,7 +2,7 @@
>  # Additional builds with specific requirements for a full VM need to
>  # be added as additional matrix: entries later on
>  os: linux
> -dist: xenial
> +dist: focal
>  language: c
>  compiler:
>    - gcc
> @@ -10,7 +10,7 @@ cache:
>    # There is one cache per branch and compiler version.
>    # characteristics of each job are used to identify the cache:
>    # - OS name (currently only linux)
> -  # - OS distribution (for Linux, xenial, trusty, or precise)
> +  # - OS distribution (for Linux, bionic or focal)
>    # - Names and values of visible environment variables set in .travis.yml 
> or Settings panel
>    timeout: 1200
>    ccache: true
> @@ -27,7 +27,7 @@ addons:
>        - libattr1-dev
>        - libbrlapi-dev
>        - libcap-ng-dev
> -      - libgcc-4.8-dev
> +      - libgcc-7-dev
>        - libgnutls28-dev
>        - libgtk-3-dev
>        - libiscsi-dev
> @@ -211,8 +211,10 @@ jobs:
>  
>      # gprof/gcov are GCC features
>      - name: "GCC gprof/gcov"
> +      dist: bionic
>        env:
> -        - CONFIG="--enable-gprof --enable-gcov --disable-pie 
> --target-list=${MAIN_SOFTMMU_TARGETS}"
> +        - CONFIG="--enable-gprof --enable-gcov --disable-libssh
> +                  --target-list=${MAIN_SOFTMMU_TARGETS}"

While the commit message describes the reason for dropping
'--disable-pie', it doesn't talk about why it adds '--disable-libssh'.
Other than that, it's working fine, according to:

  https://travis-ci.org/github/clebergnu/qemu/builds/729121964

Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>

signature.asc
Description: PGP signature