Re: [PATCH v4 04/11] disas: Move host asm annotations to tb_gen_code

[Philippe Mathieu-Daudé]

On 9/21/20 9:53 PM, Richard Henderson wrote:
> On 9/21/20 12:29 PM, Alex Bennée wrote:
>>
>> Richard Henderson <richard.henderson@linaro.org> writes:
>>
>>> Instead of creating GStrings and passing them into log_disas,
>>> just print the annotations directly in tb_gen_code.
>>>
>>> Fix the annotations for the slow paths of the TB, after the
>>> part implementing the final guest instruction.
>>>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> I guess what we loose in the inline annotation we gain in simpler code.
>> We can always grep stuff out of the logs if we need to:
> 
> What information do you think we're losing?

This in tb_gen_code()?

  note = g_string_new("[tb header & initial instruction]");

  g_string_printf(note, "[guest addr: " TARGET_FMT_lx "]",
                  tcg_ctx->gen_insn_data[insn][0]);