[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/2] nvme: allow cmb and pmr to be enabled on same device
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH v6 2/2] nvme: allow cmb and pmr to be enabled on same device |
|
Date: |
Tue, 22 Sep 2020 08:30:13 -0700 |
On Tue, Sep 22, 2020 at 11:04:25AM +0200, Klaus Jensen wrote:
> On Aug 17 08:29, Klaus Jensen wrote:
> > On Jul 30 00:50, Klaus Jensen wrote:
> > > On Jul 29 15:01, Andrzej Jakowski wrote:
> > > > So far it was not possible to have CMB and PMR emulated on the same
> > > > device, because BAR2 was used exclusively either of PMR or CMB. This
> > > > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors.
> > > >
> > > > Signed-off-by: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
> > > > ---
> > >
> > > Well, I'm certainly happy now. LGTM!
> > >
> > > Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> > >
> >
> > Are anyone willing to chip in with another review on this?
> >
>
> I think this patch is ready (and have been for some time) for inclusion,
> but would really like an additional review on this; preferably from
> Keith, since he is the one that originally mentioned that we could do
> something like this.
Yes, this does look good to me too.
Reviewed-by: Keith Busch <kbusch@kernel.org>