qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] i386: Don't try to set MSR_KVM_ASYNC_PF_EN if kernel-irqchip


From: Paolo Bonzini
Subject: Re: [PATCH] i386: Don't try to set MSR_KVM_ASYNC_PF_EN if kernel-irqchip=off
Date: Tue, 22 Sep 2020 21:49:48 +0200



Il mar 22 set 2020, 21:39 Eduardo Habkost <ehabkost@redhat.com> ha scritto:
On Tue, Sep 22, 2020 at 07:26:42PM +0200, Paolo Bonzini wrote:
> On 22/09/20 19:22, Eduardo Habkost wrote:
> > If it was possible, did KVM break live migration of
> > kernel-irqchip=off guests that enabled APF?  This would mean my
> > patch is replacing a crash with a silent migration bug.  Not nice
> > either way.
>
> Let's drop kernel-irqchip=off completely so migration is not broken. :)
>
> I'm actually serious, I don't think we need a deprecation period even.

I wasn't sure about this, but then I've noticed the man page says
"disabling the in-kernel irqchip completely is not recommended
except for debugging purposes."

Does this note apply to all architectures?

At least on ARM, Raspberry Pi 4 cannot use kernel-irqchip=on at all. But remember I am only talking about x86.

Paolo


--
Eduardo


reply via email to

[Prev in Thread] Current Thread [Next in Thread]