[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/38] qapi: Remove wildcard includes
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v2 05/38] qapi: Remove wildcard includes |
|
Date: |
Tue, 22 Sep 2020 17:37:33 -0400 |
On Tue, Sep 22, 2020 at 05:00:28PM -0400, John Snow wrote:
> Wildcard includes become hard to manage when refactoring and dealing
> with circular dependencies with strictly typed mypy.
>
> flake8 also flags each one as a warning, as it is not smart enough to
> know which names exist in the imported file.
>
> Remove them and include things explicitly by name instead.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
- Re: [PATCH v2 07/38] qapi: add pylintrc, (continued)
[PATCH v2 09/38] qapi/common.py: Add indent manager, John Snow, 2020/09/22
[PATCH v2 05/38] qapi: Remove wildcard includes, John Snow, 2020/09/22
[PATCH v2 12/38] qapi/common.py: check with pylint, John Snow, 2020/09/22
[PATCH v2 04/38] qapi: Prefer explicit relative imports, John Snow, 2020/09/22