Re: [PATCH v8 3/7] usb/hcd-xhci: Split pci wrapper for xhci base model

[Gerd Hoffmann]

  Hi,

> This patch sets the base to use xhci as sysbus model, for which pci
> specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment
> msi/msix interrupts handling is moved under XHCIPCIState. Made required
> changes for qemu-xhci-nec.

Progress.  vmstate loads fine ;)

Does not work though.  usb-tablet stops working after migration :(

> @@ -3561,11 +3458,7 @@ static int usb_xhci_post_load(void *opaque, int 
> version_id)
>      }
>  
>      for (intr = 0; intr < xhci->numintrs; intr++) {
> -        if (xhci->intr[intr].msix_used) {
> -            msix_vector_use(pci_dev, intr);
> -        } else {
> -            msix_vector_unuse(pci_dev, intr);
> -        }
> +        xhci_intr_update(xhci, intr);
>      }
>  
>      return 0;

I suspect this is the problem.  I guess we should add
usb_xhci_post_load_pci + usb_xhci_post_load_sysbus and move irq handling
to these functions.

take care,
  Gerd