qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] docs: Document the throttle block filter


From: Kevin Wolf
Subject: Re: [PATCH] docs: Document the throttle block filter
Date: Wed, 23 Sep 2020 18:30:26 +0200

Am 23.09.2020 um 17:59 hat Alberto Garcia geschrieben:
> On Wed 23 Sep 2020 05:55:22 PM CEST, Kevin Wolf wrote:
> >> +A throttle-group can also be created with the -object command line
> >> +option but at the moment there is no way to pass a 'limits' parameter
> >> +that contains a ThrottleLimits structure. The solution is to set the
> >> +individual values directly, like in this example:
> >> +
> >> +   -object throttle-group,id=group0,x-iops-total=1000,x-bps-write=2097152
> >> +
> >> +Note however that this not stable API (hence the 'x-' prefixes) and
> >> +can change or disappear in the future.
> >
> > Should we use a stronger wording here, like "will disappear when
> > -object gains support for structured options and enables use of
> > 'limits'"?
> 
> Sounds good, I can send v2 if you want, or feel free to change the
> sentence yourself when applying the patch now.

Ok, I just did that and also gave the sentence a verb while at it. ;-)

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]