qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 36/38] qapi/visit.py: assert tag_member contains a QAPISch


From: John Snow
Subject: Re: [PATCH v2 36/38] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType
Date: Wed, 23 Sep 2020 18:13:30 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/23/20 3:15 PM, Eduardo Habkost wrote:
On Tue, Sep 22, 2020 at 05:00:59PM -0400, John Snow wrote:
Signed-off-by: John Snow <jsnow@redhat.com>

This for making mypy happy, correct?  An explanation in the commit
message would be nice.

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>


Yes, it's for mypy -- but it's a runtime visible change. Technically our type system isn't mature enough to express this constraint natively, so it's being carried around as developer knowledge.

This formalizes that knowledge, albeit in a very crude way.

I've amended the commit msg.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]