[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH PROTOTYPE 5/6] virtio-mem: Require only RAM_BLOCK_DISCARD_T_COORD
From: |
David Hildenbrand |
Subject: |
[PATCH PROTOTYPE 5/6] virtio-mem: Require only RAM_BLOCK_DISCARD_T_COORDINATED discards |
Date: |
Thu, 24 Sep 2020 18:04:22 +0200 |
We implement the SparseRamHandler interface and properly communicate
changes by notifying listeners - especially in all scenarios
- when memory becomes usable by the guest
- when memory becomes unusable by the guest (and we discard memory)
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/virtio/virtio-mem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index e23969eaed..efeff7c64c 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -531,7 +531,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
Error **errp)
return;
}
- if (ram_block_discard_require(true)) {
+ if (ram_block_discard_type_require(RAM_BLOCK_DISCARD_T_COORDINATED, true))
{
error_setg(errp, "Discarding RAM is disabled");
return;
}
@@ -539,7 +539,7 @@ static void virtio_mem_device_realize(DeviceState *dev,
Error **errp)
ret = ram_block_discard_range(rb, 0, qemu_ram_get_used_length(rb));
if (ret) {
error_setg_errno(errp, -ret, "Unexpected error discarding RAM");
- ram_block_discard_require(false);
+ ram_block_discard_type_require(RAM_BLOCK_DISCARD_T_COORDINATED, false);
return;
}
@@ -579,7 +579,7 @@ static void virtio_mem_device_unrealize(DeviceState *dev)
virtio_del_queue(vdev, 0);
virtio_cleanup(vdev);
g_free(vmem->bitmap);
- ram_block_discard_require(false);
+ ram_block_discard_type_require(RAM_BLOCK_DISCARD_T_COORDINATED, false);
}
static int virtio_mem_restore_unplugged(VirtIOMEM *vmem)
--
2.26.2
- [PATCH PROTOTYPE 0/6] virtio-mem: vfio support, David Hildenbrand, 2020/09/24
- [PATCH PROTOTYPE 2/6] virtio-mem: Impelement SparseRAMHandler interface, David Hildenbrand, 2020/09/24
- [PATCH PROTOTYPE 3/6] vfio: Implement support for sparse RAM memory regions, David Hildenbrand, 2020/09/24
- [PATCH PROTOTYPE 4/6] memory: Extend ram_block_discard_(require|disable) by two discard types, David Hildenbrand, 2020/09/24
- [PATCH PROTOTYPE 5/6] virtio-mem: Require only RAM_BLOCK_DISCARD_T_COORDINATED discards,
David Hildenbrand <=
- [PATCH PROTOTYPE 6/6] vfio: Disable only RAM_BLOCK_DISCARD_T_UNCOORDINATED discards, David Hildenbrand, 2020/09/24
- [PATCH PROTOTYPE 1/6] memory: Introduce sparse RAM handler for memory regions, David Hildenbrand, 2020/09/24
- Re: [PATCH PROTOTYPE 0/6] virtio-mem: vfio support, no-reply, 2020/09/24
- Re: [PATCH PROTOTYPE 0/6] virtio-mem: vfio support, Dr. David Alan Gilbert, 2020/09/29