qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 0/7] coroutines: generate wrapper code


From: Eric Blake
Subject: Re: [PATCH v9 0/7] coroutines: generate wrapper code
Date: Thu, 24 Sep 2020 14:00:34 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/24/20 1:54 PM, Vladimir Sementsov-Ogievskiy wrote:
Hi all!

The aim of the series is to reduce code-duplication and writing
parameters structure-packing by hand around coroutine function wrappers.

Benefits:
  - no code duplication
  - less indirection

v9: Thanks to Eric, I used commit message tweaks and rebase-conflict solving 
from his git.
01: add Philippe's, Stefan's r-bs
02: - add Philippe's, Stefan's r-bs
     - commit message tweaks stolen from Eric's git :)

LOL: "stolen" makes it sound like a crime was committed ;) I find it to be one of the joys of open source when my ideas show up in someone else's work when properly attributed, as you did here. [Maybe the recent push towards a conscious language initiative has let me hone in on something that turned out humorous to me, but might not be as obvious to someone less fluent in English idioms]

At any rate, I'm glad my rebase efforts helped.

03: add Philippe's, Stefan's r-bs
04: - wording/grammar by Eric (partly, stolen from repo)
     - ref new file in docs/devel/index.rst
     - use 644 rights and recommended header for python script
     - call gen_header() once
     - rename gen_wrappers_file to gen_wrappers
05: add Stefan's r-b
06: add Philippe's, Stefan's r-bs
07: Stefan's r-b


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]