[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/16] qapi/expr.py: move string check upwards in check_type
From: |
Cleber Rosa |
Subject: |
Re: [PATCH 05/16] qapi/expr.py: move string check upwards in check_type |
Date: |
Thu, 24 Sep 2020 20:22:34 -0400 |
On Tue, Sep 22, 2020 at 05:13:02PM -0400, John Snow wrote:
> It's a simple case, shimmy the early return upwards.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
I'm only acking this because of the very graphical "shimmy dance"
movie that played in my mind.
Reviewed-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
[PATCH 02/16] qapi/expr.py: Check for dict instead of OrderedDict, John Snow, 2020/09/22
[PATCH 05/16] qapi/expr.py: move string check upwards in check_type, John Snow, 2020/09/22
[PATCH 06/16] qapi/expr.py: Check type of 'data' member, John Snow, 2020/09/22
[PATCH 07/16] qapi/expr.py: Add casts in a few select cases, John Snow, 2020/09/22
[PATCH 08/16] qapi/expr.py: add type hint annotations, John Snow, 2020/09/22