[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/16] qapi/expr.py: rewrite check_if
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH 09/16] qapi/expr.py: rewrite check_if |
|
Date: |
Thu, 24 Sep 2020 20:50:37 -0400 |
On Tue, Sep 22, 2020 at 05:13:06PM -0400, John Snow wrote:
> This is a only minor rewrite to address some minor style nits. Don't
> compare against the empty list to check for the empty condition, and
> move the normalization forward to unify the check on the now-normalized
> structure.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
And just to make sure there was not change in the logic:
Tested-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 06/16] qapi/expr.py: Check type of 'data' member, (continued)
- [PATCH 07/16] qapi/expr.py: Add casts in a few select cases, John Snow, 2020/09/22
- [PATCH 08/16] qapi/expr.py: add type hint annotations, John Snow, 2020/09/22
- [PATCH 09/16] qapi/expr.py: rewrite check_if, John Snow, 2020/09/22
- [PATCH 10/16] qapi/expr.py: Remove single-letter variable, John Snow, 2020/09/22
- [PATCH 11/16] qapi/expr.py: enable pylint checks, John Snow, 2020/09/22
- [PATCH 12/16] qapi/expr.py: Add docstrings, John Snow, 2020/09/22