[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] hw/i386/pc: add max combined fw size as machine configura
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH v4] hw/i386/pc: add max combined fw size as machine configuration option |
|
Date: |
Fri, 25 Sep 2020 10:23:31 +0200 |
Hi,
> > + pcms->max_fw_size = 8 * MiB; /* use default */
[ ... ]
> All I'm saying is that the "/* use default */" comment should not be
> copied from "max_ram_below_4g" to "max_fw_size", because the (assumed)
> meaning of the original comment does not apply to the new field.
Fully agree.
take care,
Gerd