Re: [PATCH 3/7] s390x/pci: create a header dedicated to PCI CLP

[Cornelia Huck]

On Sat, 19 Sep 2020 11:34:28 -0400
Matthew Rosato <mjrosato@linux.ibm.com> wrote:

> From: Pierre Morel <pmorel@linux.ibm.com>
> 
> To have a clean separation between s390-pci-bus.h and s390-pci-inst.h
> headers we export the PCI CLP instructions in a dedicated header.
> 
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
>  hw/s390x/s390-pci-bus.h  |   1 +
>  hw/s390x/s390-pci-clp.h  | 211 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  hw/s390x/s390-pci-inst.h | 196 -------------------------------------------
>  3 files changed, 212 insertions(+), 196 deletions(-)
>  create mode 100644 hw/s390x/s390-pci-clp.h

Looks sane; but I wonder whether we should move the stuff under
include/hw/s390x/.