[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v4 53/70] target/riscv: rvv-1.0: floating-point slide instructi
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC v4 53/70] target/riscv: rvv-1.0: floating-point slide instructions |
|
Date: |
Fri, 25 Sep 2020 11:31:06 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/25/20 1:21 AM, Frank Chang wrote:
> I'm happy to reuse vslide1up_vx helper functions.
>
> However, opfvf_trans() takes helper prototype of:
> /typedef void gen_helper_opfvf(TCGv_ptr, TCGv_ptr, TCGv_i64, TCGv_ptr,
> TCGv_env, TCGv_i32);/
> but vslide1up_vx helper function's prototype is:
> /typedef void gen_helper_opivx(TCGv_ptr, TCGv_ptr, TCGv, TCGv_ptr,
> TCGv_env, TCGv_i32);/
>
> The third argument has different types, not sure if it's worth it to sync them
> all to TCGv_i64.
Ah, yes.
It could be useful to always widen to TCGv_i64 -- that's what gvec does in
general. But I certainly won't insist.
r~