qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead o


From: Markus Armbruster
Subject: Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo
Date: Mon, 28 Sep 2020 15:04:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Peter Maydell <peter.maydell@linaro.org> writes:

> On Fri, 25 Sep 2020 at 20:25, <no-reply@patchew.org> wrote:
>
>> In file included from ../src/qapi/qapi-schema.json:78:
>> ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at least 
>> 13 spaces)
>
> This is yet another mis-indented line in a change to the QAPI
> doc-comments (commit 4c437254b807). It hit master in the
> latest migration pull after I'd sent out this patchseries
> but before patchew got round to testing..

Obvious fixup for your PATCH 01:

diff --git a/qapi/migration.json b/qapi/migration.json
index 7d9342c064..7f5e6fd681 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1744,9 +1744,9 @@
 # Information about current dirty page rate of vm.
 #
 # @dirty-rate: @dirtyrate describing the dirty page rate of vm
-#          in units of MB/s.
-#          If this field returns '-1', it means querying has not
-#          yet started or completed.
+#              in units of MB/s.
+#              If this field returns '-1', it means querying has not
+#              yet started or completed.
 #
 # @status: status containing dirtyrate query status includes
 #          'unstarted' or 'measuring' or 'measured'

Happy to fix it up in my tree.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]