qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD


From: Peter Maydell
Subject: Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD
Date: Tue, 29 Sep 2020 09:58:17 +0100

On Mon, 28 Sep 2020 at 23:02, Kamil Rytarowski <kamil@netbsd.org> wrote:
>
> Personally, I prefer using the system headers. but if you want to use
> the GCC builtins, please go for it.

I'd agree if the system header approach was cross-platform
or if this was a BSD-only program or if we were aiming for
complete compiler-implementation independence, but since we
rely on GCC/clang all over the place already it seems nicer to
avoid all the machinery for identifying which of the multiple
different system header implementations is present, and
instead just have a single implementation that works on
all the hosts we care about...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]