Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

[Ani Sinha]

On Tue, Sep 29, 2020 at 4:28 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Sep 29, 2020 at 04:20:15PM +0530, Ani Sinha wrote:
> >  as
> >
> > On Tue, Sep 29, 2020 at 4:11 PM Ani Sinha <ani@anisinha.ca> wrote:
> > >
> > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > > >
> > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote:
> > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote:
> > > > > >
> > > > > > In your pull request the following patch is completely screwed up:
> > > > > >
> > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e
> > > > > > Author: Ani Sinha <ani@anisinha.ca>
> > > > > > Date:   Tue Sep 29 03:22:52 2020 -0400
> > > > > >
> > > > > >     tests/acpi: update golden master DSDT binary table blobs for q35
> > > > > >
> > > > > >
> > > > > > This is not my patch. It has all sorts of changes which does not
> > > > > > belong there. Can you please check?
> > > > >
> > > > > See 
> > > > > 20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/">https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/
> > > >
> > > >
> > > > I had to regenerate the binary, yes. That's par for the course.
> > > > But it looks like I added disasssembled files. Will fix up and drop,
> > > > thanks for noticing this.
> >
> > It's probably worthwhile to regenerate DSDT.hpbrroot as well and then
> > do the diff and compare.
>
> They are all regenerated by tests/data/acpi/rebuild-expected-aml.sh
>
> What is important is to check the changes and not trust them blindly.

Yes what I meant was if you are regenerating the source blob with
which you are diff-ing, you should generate the destination blob as
well so that we can compare apples to apples.

>
> Do you see anything unexpected? It is easy to run
>
> tests/data/acpi/disassemle-aml.sh -o <output directory>
>
> on multiple versions and see what is going on.
> Care to do this?
>
>
> --
> MST
>