qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] migration/dirtyrate: present dirty rate only when que


From: Eric Blake
Subject: Re: [PATCH v2 2/2] migration/dirtyrate: present dirty rate only when querying the rate has completed
Date: Tue, 29 Sep 2020 07:30:36 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/28/20 10:42 PM, Chuan Zheng wrote:
Make dirty_rate field optional, present dirty rate only when querying
the rate has completed.
The qmp results is shown as follow:
@unstarted:
{"return":{"status":"unstarted","start-time":0,"calc-time":0},"id":"libvirt-12"}
@measuring:
{"return":{"status":"measuring","start-time":102931,"calc-time":1},"id":"libvirt-85"}
@measured:
{"return":{"status":"measured","dirty-rate":4,"start-time":150146,"calc-time":1},"id":"libvirt-15"}

The "id":"libvirt-..." obviously come from different libvirt sessions, since they are in non-monotonic order. Not a show-stopper, since it is only a commit comment.


Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
---
  migration/dirtyrate.c | 3 +--
  qapi/migration.json   | 8 +++-----
  2 files changed, 4 insertions(+), 7 deletions(-)


Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]