Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros

[Philippe Mathieu-Daudé]

On 9/28/20 7:28 PM, Taylor Simpson wrote:
> macros to interface with the generator
> macros referenced in instruction semantics
> 
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>  target/hexagon/macros.h | 654 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 654 insertions(+)
>  create mode 100644 target/hexagon/macros.h
> 
> diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
> new file mode 100644
> index 0000000..34831d4
> --- /dev/null
> +++ b/target/hexagon/macros.h
> @@ -0,0 +1,654 @@
> +/*
> + *  Copyright(c) 2019-2020 Qualcomm Innovation Center, Inc. All Rights 
> Reserved.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef HEXAGON_MACROS_H
> +#define HEXAGON_MACROS_H
> +
> +#include "qemu/osdep.h"

Please do not include "qemu/osdep.h" in header.

> +#include "qemu/host-utils.h"

"qemu/host-utils.h" doesn't seem used.

> +#include "cpu.h"
> +#include "hex_regs.h"
> +#include "reg_fields.h"
> +
[...]