[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 00/14] Reverse debugging
From: |
no-reply |
Subject: |
Re: [PATCH v6 00/14] Reverse debugging |
Date: |
Tue, 29 Sep 2020 08:51:58 -0700 (PDT) |
Patchew URL:
https://patchew.org/QEMU/160137726426.31007.12061315974029139983.stgit@pasha-ThinkPad-X280/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 160137726426.31007.12061315974029139983.stgit@pasha-ThinkPad-X280
Subject: [PATCH v6 00/14] Reverse debugging
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
42ed9ff tests/acceptance: add reverse debugging test
9e6312b replay: create temporary snapshot at debugger connection
e5b95b0 replay: describe reverse debugging in docs/replay.txt
47c1dc5 gdbstub: add reverse continue support in replay mode
9f812ce gdbstub: add reverse step support in replay mode
47580b0 replay: flush rr queue before loading the vmstate
3a46821 replay: implement replay-seek command
333560c replay: introduce breakpoint at the specified step
912d979 replay: introduce info hmp/qmp command
f174f33 qapi: introduce replay.json for record/replay-related stuff
fa8bc32 migration: introduce icount field for snapshots
1785cc5 qcow2: introduce icount field for snapshots
5d53fea replay: provide an accessor for rr filename
84a429f replay: don't record interrupt poll
=== OUTPUT BEGIN ===
1/14 Checking commit 84a429fe86d2 (replay: don't record interrupt poll)
2/14 Checking commit 5d53feae3272 (replay: provide an accessor for rr filename)
3/14 Checking commit 1785cc5df6f7 (qcow2: introduce icount field for snapshots)
4/14 Checking commit fa8bc32691b4 (migration: introduce icount field for
snapshots)
ERROR: trailing whitespace
#226: FILE: tests/qemu-iotests/267.out:37:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#237: FILE: tests/qemu-iotests/267.out:48:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#248: FILE: tests/qemu-iotests/267.out:73:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#259: FILE: tests/qemu-iotests/267.out:98:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#270: FILE: tests/qemu-iotests/267.out:109:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#281: FILE: tests/qemu-iotests/267.out:123:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#292: FILE: tests/qemu-iotests/267.out:138:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#303: FILE: tests/qemu-iotests/267.out:149:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#312: FILE: tests/qemu-iotests/267.out:156:
+1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#323: FILE: tests/qemu-iotests/267.out:170:
+-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#332: FILE: tests/qemu-iotests/267.out:177:
+1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
ERROR: trailing whitespace
#338: FILE: tests/qemu-iotests/267.out:181:
+1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
$
total: 12 errors, 0 warnings, 259 lines checked
Patch 4/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/14 Checking commit f174f339f352 (qapi: introduce replay.json for
record/replay-related stuff)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93:
new file mode 100644
total: 0 errors, 1 warnings, 78 lines checked
Patch 5/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/14 Checking commit 912d9793f5a5 (replay: introduce info hmp/qmp command)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#122:
new file mode 100644
total: 0 errors, 1 warnings, 120 lines checked
Patch 6/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/14 Checking commit 333560c38d6a (replay: introduce breakpoint at the
specified step)
8/14 Checking commit 3a46821e71ef (replay: implement replay-seek command)
9/14 Checking commit 47580b0a465e (replay: flush rr queue before loading the
vmstate)
10/14 Checking commit 9f812ced7a0a (gdbstub: add reverse step support in replay
mode)
WARNING: line over 80 characters
#220: FILE: replay/replay-debugging.c:237:
+ replay_seek(replay_get_current_icount() - 1, replay_stop_vm_debug,
&err);
total: 0 errors, 1 warnings, 201 lines checked
Patch 10/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/14 Checking commit 47c1dc583443 (gdbstub: add reverse continue support in
replay mode)
WARNING: line over 80 characters
#150: FILE: replay/replay-debugging.c:300:
+ replay_seek(replay_get_current_icount() - 1, replay_continue_stop,
&err);
total: 0 errors, 1 warnings, 146 lines checked
Patch 11/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/14 Checking commit e5b95b028f0d (replay: describe reverse debugging in
docs/replay.txt)
13/14 Checking commit 9e6312b2ec00 (replay: create temporary snapshot at
debugger connection)
14/14 Checking commit 42ed9ffcae51 (tests/acceptance: add reverse debugging
test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 215 lines checked
Patch 14/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/160137726426.31007.12061315974029139983.stgit@pasha-ThinkPad-X280/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v6 06/14] replay: introduce info hmp/qmp command, (continued)
- [PATCH v6 06/14] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 07/14] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 08/14] replay: implement replay-seek command, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 09/14] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 10/14] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 11/14] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 12/14] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 13/14] replay: create temporary snapshot at debugger connection, Pavel Dovgalyuk, 2020/09/29
- [PATCH v6 14/14] tests/acceptance: add reverse debugging test, Pavel Dovgalyuk, 2020/09/29
- Re: [PATCH v6 00/14] Reverse debugging,
no-reply <=