Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine

[Philippe Mathieu-Daudé]

On 9/30/20 7:08 AM, Dongjiu Geng wrote:
> On 2020/9/29 20:56, Philippe Mathieu-Daudé wrote:
>> As only the Virt machine uses the RAS Virtualization feature (see
>> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"),
>> restrict the APEI tables generation code to the virt machine.
> 
> APEI is a generic feature for X86 and arm64.  X86 platform also can use it, 
> although currently it was mainly
> used by ARM64. what is reason that we restrict APEI tables generation to the 
> 'virt' machine?

It is currently only selected on (all) the ARM machines, not the X86
ones. I am simply restricting it to the 'virt' machine which is the
single one enabling the RAS. Without RAS the table is not built, so
for the case of the SBSA-Ref machine this code is unreachable, no need
to select ACPI_APEI.

When a X86 machine configure a RAS it will have to 'select ACPI_APEI'
to get it built (I'm not forbidding it, I'm restricting it to where
it is used).

> 
>>
>> Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware 
>> error fw_cfg blob")
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Xiang Zheng <zhengxiang9@huawei.com>
>> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Dongjiu Geng <gengdongjiu@huawei.com>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>  default-configs/arm-softmmu.mak | 1 -
>>  hw/arm/Kconfig                  | 1 +
>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/default-configs/arm-softmmu.mak 
>> b/default-configs/arm-softmmu.mak
>> index 9a94ebd0be..08a32123b4 100644
>> --- a/default-configs/arm-softmmu.mak
>> +++ b/default-configs/arm-softmmu.mak
>> @@ -43,4 +43,3 @@ CONFIG_FSL_IMX7=y
>>  CONFIG_FSL_IMX6UL=y
>>  CONFIG_SEMIHOSTING=y
>>  CONFIG_ALLWINNER_H3=y
>> -CONFIG_ACPI_APEI=y
>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
>> index f303c6bead..7d040827af 100644
>> --- a/hw/arm/Kconfig
>> +++ b/hw/arm/Kconfig
>> @@ -26,6 +26,7 @@ config ARM_VIRT
>>      select ACPI_MEMORY_HOTPLUG
>>      select ACPI_HW_REDUCED
>>      select ACPI_NVDIMM
>> +    select ACPI_APEI
>>  
>>  config CHEETAH
>>      bool
>>
>