qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 13/13] qemu/atomic.h: rename atomic_ to qatomic_


From: Paolo Bonzini
Subject: Re: [PULL 13/13] qemu/atomic.h: rename atomic_ to qatomic_
Date: Wed, 30 Sep 2020 17:52:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 30/09/20 17:28, Andrew Jones wrote:
> pvrdma_ring.h is an update-linux-headers.sh file. When running the
> script again we lose the atomic_ to qatomic_ renaming. I've hacked
> the script by adding
> 
>  -e 's/\batomic_read/qatomic_read/g;s/\batomic_set/qatomic_set/g'
> 
> to the cp_portable() sed command, but only considering the two
> qatomic_ functions currently used is obviously not a complete
> solution.
> 
> Any ideas?

My first thought was that it's strange that there are atomics in a uapi/
file, and in fact the file is not uapi/ but rather part of the driver.
I think we should just copy the file into QEMU sources, and remove it
from update-linux-headers.sh.  The "s/atomic_t/int/" can go as well.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]