[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] linux-user: correct errno returned from accept4() syscall
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] linux-user: correct errno returned from accept4() syscall |
Date: |
Wed, 30 Sep 2020 19:19:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 30/09/2020 à 17:16, Matus Kysel a écrit :
> accept4() returned wrong errno, that did not match current linux
>
> Signed-off-by: Matus Kysel <mkysel@tachyum.com>
> ---
> linux-user/syscall.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 897d20c076..5b8c20cf21 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3491,16 +3491,16 @@ static abi_long do_accept4(int fd, abi_ulong
> target_addr,
> return get_errno(safe_accept4(fd, NULL, NULL, host_flags));
> }
>
> - /* linux returns EINVAL if addrlen pointer is invalid */
> + /* linux returns EFAULT if addrlen pointer is invalid */
> if (get_user_u32(addrlen, target_addrlen_addr))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> if ((int)addrlen < 0) {
> return -TARGET_EINVAL;
> }
>
> if (!access_ok(VERIFY_WRITE, target_addr, addrlen))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> addr = alloca(addrlen);
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>