[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 37/46] qapi/instrospect.py: add preliminary type hint anno
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v4 37/46] qapi/instrospect.py: add preliminary type hint annotations |
Date: |
Wed, 30 Sep 2020 14:31:10 -0400 |
On Wed, Sep 30, 2020 at 12:31:41AM -0400, John Snow wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
>
> The typing of _make_tree and friends is a bit involved, but it can be
> done with some stubbed out types and a bit of elbow grease. The
> forthcoming patches attempt to make some simplifications, but having the
> type hints in advance can aid in review.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
- Re: [PATCH v4 40/46] qapi/introspect.py: replace 'extra' dict with 'comment' argument, (continued)
- [PATCH v4 42/46] qapi/types.py: add type hint annotations, John Snow, 2020/09/30
- [PATCH v4 44/46] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType, John Snow, 2020/09/30
- [PATCH v4 45/46] qapi/visit.py: remove unused parameters from gen_visit_object, John Snow, 2020/09/30
- [PATCH v4 39/46] qapi/introspect.py: Unify return type of _make_tree(), John Snow, 2020/09/30
- [PATCH v4 41/46] qapi/introspect.py: create a typed 'Node' data structure, John Snow, 2020/09/30
- [PATCH v4 37/46] qapi/instrospect.py: add preliminary type hint annotations, John Snow, 2020/09/30
- Re: [PATCH v4 37/46] qapi/instrospect.py: add preliminary type hint annotations,
Eduardo Habkost <=
- [PATCH v4 46/46] qapi/visit.py: add type hint annotations, John Snow, 2020/09/30
- [PATCH v4 43/46] qapi/types.py: remove one-letter variables, John Snow, 2020/09/30