[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/10] Fix line over 80 characters warning
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 00/10] Fix line over 80 characters warning |
|
Date: |
Tue, 20 Oct 2020 12:13:46 +0100 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Tue, Oct 20, 2020 at 04:30:13AM +0800, Gan Qixin wrote:
> Hi all,
> I used scripts/checkpatch.pl to find that many files in the hw directory
> contain lines with more than 80 characters. Therefore, I splited some lines to
> fix this warning.
Do we really need to still fix ourselves to a 80 col limit in the
year 2020 ?
Linux increased their max line length to 100 chars and even set
checkpatch.pl to not complain about that limit unless --strict
is given.
80 chars is fine as a "wish list" target, but IMHO the code often
benefits more from exceeding 80 chars, and not wrapping.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 04/10] hw/intc/:split some lines containing more than 80 characters, (continued)
- [PATCH 04/10] hw/intc/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 07/10] hw/pci-host/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 01/10] hw/virtio/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 03/10] hw/ide/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 05/10] hw/misc/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 06/10] hw/pci/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 02/10] hw/core/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 08/10] hw/char/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 09/10] hw/input/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- [PATCH 10/10] hw/riscv/:split some lines containing more than 80 characters, Gan Qixin, 2020/10/20
- Re: [PATCH 00/10] Fix line over 80 characters warning,
Daniel P . Berrangé <=
- Re: [PATCH 00/10] Fix line over 80 characters warning, Peter Maydell, 2020/10/20