Re: [PATCH] tests/acceptance: fix timeout for vm.wait

[John Snow]

On 12/2/20 1:31 AM, Pavel Dovgalyuk wrote:
> > > > This patch adds timeout parameter to vm.wait() calls, because the 
> > > > default
> > > > value is just 30 seconds, and tests may last for more time.
> >
> > This doesn't sound right -- the timeout isn't meant to be for the 
> > entire duration of the test, the timeout is from the time of issuing a 
> > shutdown command until the time the VM actually shuts down. Ideally, 
> > that should not take a particularly long time in a well-behaved test.
> >
> > Why is it lasting longer than 30 seconds?
>
> These are complex Linux boot&execution tests.
> Such loading process could take more than 30 seconds.
> E.g., BootLinux tests have timeout of 900 seconds.

This timeout should only count towards the time spent *shutting down*, 
not the time to run the entire test. 30 seconds used to be enough time 
for this to happen on gitlab, if it's taking longer than that I am 
worried that something has gone wrong.

Where were the failures observed, and on what tests? Are there logs I 
can review?

--js