[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/28] target/arm: Implement VLDR/VSTR system register
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 09/28] target/arm: Implement VLDR/VSTR system register |
|
Date: |
Thu, 3 Dec 2020 10:14:59 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 12/3/20 5:39 AM, Peter Maydell wrote:
> On Tue, 1 Dec 2020 at 13:11, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> On 11/19/20 3:55 PM, Peter Maydell wrote:
>>> + gen_aa32_st32(s, value, addr, get_mem_index(s));
>>
>> This is MemA, so should use
>>
>> gen_aa32_st_i32(s, value, addr, get_mem_index(s),
>> MO_UL | MO_ALIGN);
>>
>> a-la my patch set from last week fixing other instances.
>
> Also " | s->be_data", right ?
Ho hum, yes. I saw your comment on this in the alignment patch set and I'll
think about A Better Way.
r~