Re: [PATCH 1/1] ui/gtk: Launching GTK UI with OpenGL on causes the refreshrate update to not run

[Philippe Mathieu-Daudé]

On 12/6/20 12:42 PM, Philippe Mathieu-Daudé wrote:
> Hi Nikola,
> 
> On 12/6/20 11:43 AM, Nikola Pavlica wrote:
>> I've discussed this issue back January and September. But it still
>> occurs on my machine, despite the two patches.

Oh, also, instead of "my machine", please provide more information about
your setup (installed versions), so we might eventually reproduce.

> This time, the issue is
>> that the UI refresh rate doesn't get updated when I launch QEMU with
>> gl=on. My fix for this issue is to move the code for updating the
>> refresh rate above the code that checks for OpenGL.
>>
>> Or because OpenGL is meant to be called back with the "render" callback,
>> should we instead add the refresh 
>> rate checking code there?
> 
> This is not my area, but I think you are right, the the refresh rate
> should be updated in the "render" callback.
> 
> To speed things you can send another patch, and Gerd will pick the
> correct/best one :)
> 
>> Anyway, regardless of method, I'm happy with any solution that just
>> fixes the issue.
>> Signed-off-by: Nikola Pavlica (pavlica.nikola@gmail.com)---