qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] python, tests: do not use short-form boolean options


From: John Snow
Subject: Re: [PATCH] python, tests: do not use short-form boolean options
Date: Mon, 7 Dec 2020 14:17:52 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 11/17/20 9:32 AM, Markus Armbruster wrote:
Paolo Bonzini <pbonzini@redhat.com> writes:

On 17/11/20 10:20, Markus Armbruster wrote:
-            chardev = ('socket,id=console,path=%s,server,nowait' %
+            chardev = ('socket,id=console,path=%s,server=yes,wait=no' %

Let's stick to the canonical 'on' and 'off'.

That was on purpose (for extra coverage and not just because variety is
the spice of life).  But I can use the canonical values as well if you
prefer.

I think the place for extra coverage is tests/test-qemu-opts.c.



Seconded; steer machine.py et al to something like a reference implementation for how we want people to drive QEMU.

--js




reply via email to

[Prev in Thread] Current Thread [Next in Thread]