qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/15] vl: make qemu_get_machine_opts static


From: Paolo Bonzini
Subject: Re: [PATCH 10/15] vl: make qemu_get_machine_opts static
Date: Tue, 8 Dec 2020 09:13:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 08/12/20 03:16, Daniel Henrique Barboza wrote:
2) find a way to make object_property_get_str() to return kvm_type =
 NULL if the 'kvm_type' option is absent  and keep spapr code
untouched. I don't have the knowledge to assess how hard this would
be.

3) I can change the pseries logic to add an explicit default value
for kvm_type=NULL or kvm_type='' (i.e. no user input is given). We're
already doing that in a sense, but it's not exposed to the user. I
would call it 'auto' and expose it to the user as default value if no
kvm_type is explictly set. This would enhance user experience a bit
and avoid having to deal with a scenario where kvm_type=(blank) is a
valid input.


David, if you think (3) is tolerable let me know and I can send a
patch. IMO this change adds a bit of value regardless of Paolo's
change.

Yes, I agree that (3) is a good idea. If you send a patch I can integrate it in the series.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]