Re: [PATCH 3/4] qmp: Allow setting -action parameters on the fly

[Alejandro Jimenez]

On 12/8/2020 2:58 PM, Paolo Bonzini wrote:
> On 08/12/20 20:57, Paolo Bonzini wrote:
> > On 08/12/20 20:14, Alejandro Jimenez wrote:
> > >   ##
> > > +# @reboot-set-action:
> > > +#
> > > +# Set reboot action
> > > +#
> > > +# Since: 6.0
> > > +##
> > > +{ 'command': 'reboot-set-action', 'data' : {'action': 
> > > 'RebootAction'} }
> > > +
> > > +##
> > > +# @shutdown-set-action:
> > > +#
> > > +# Set shutdown action
> > > +#
> > > +# Since: 6.0
> > > +##
> > > +{ 'command': 'shutdown-set-action', 'data' : {'action': 
> > > 'ShutdownAction'} }
> > > +
> > > +##
> > > +# @panic-set-action:
> > > +#
> > > +# Set panic action
> > > +#
> > > +# Since: 6.0
> > > +##
> > > +{ 'command': 'panic-set-action', 'data' : {'action': 'PanicAction'} }
> > > +
> > > +##
> >
> > What about a single action-set command with arguments reboot, 
> > shutdown and panic?
>
> (and watchdog, of course)?
Just to make sure I understand the request: an action-set QMP command 
would need to take two arguments: an event 
(reboot|shutdown|panic|watchdog), and a valid action for that event 
type, akin to what set_runstate_action() does. I'll work on it.

Alejandro
> Paolo