[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallbac
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback |
|
Date: |
Thu, 10 Dec 2020 14:46:43 +0000 |
On Thu, 10 Dec 2020 at 14:32, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 12/10/20 2:47 PM, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Since commit efc6c07 ("configure: Add a test for the minimum compiler
> > version"), QEMU explicitely depends on GCC >= 4.8.
> >
> > (clang >= 3.4 advertizes itself as GCC >= 4.2 compatible and supports
> > __builtin_expect too)
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Shouldn't it becleaner to test in the configure script or Meson that
> likely() and unlikely() are not defined, and define them here
> unconditionally?
That sounds like way more infrastructure than we need if
just checking "is it already defined" is sufficient...
-- PMM
- [PATCH v3 00/13] Remove GCC < 4.8 checks, marcandre . lureau, 2020/12/10
- [PATCH v3 04/13] qemu-plugin.h: remove GCC < 4, marcandre . lureau, 2020/12/10
- [PATCH v3 05/13] tests: remove GCC < 4 fallbacks, marcandre . lureau, 2020/12/10
- [PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON, marcandre . lureau, 2020/12/10
- [PATCH v3 07/13] compiler.h: explicit case for Clang printf attribute, marcandre . lureau, 2020/12/10
- [PATCH v3 08/13] audio: remove GNUC & MSVC check, marcandre . lureau, 2020/12/10