[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/13] qga: Replace an unreachable error by abort()
From: |
Markus Armbruster |
Subject: |
[PULL 08/13] qga: Replace an unreachable error by abort() |
Date: |
Thu, 10 Dec 2020 17:31:27 +0100 |
check_suspend_mode()'s error message
Parameter 'mode' expects GuestSuspendMode
makes no sense to users: GuestSuspendMode is a C enum. Fortunately,
it is unreachable. Replace it by abort().
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201113082626.2725812-8-armbru@redhat.com>
---
qga/commands-win32.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 300b87c859..87dc43e837 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1441,8 +1441,7 @@ static void check_suspend_mode(GuestSuspendMode mode,
Error **errp)
}
break;
default:
- error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "mode",
- "GuestSuspendMode");
+ abort();
}
}
--
2.26.2
- [PULL 00/13] Miscellaneous patches for 2020-12-10, Markus Armbruster, 2020/12/10
- [PULL 12/13] qapi: Normalize version references x.y.0 to just x.y, Markus Armbruster, 2020/12/10
- [PULL 04/13] block: Improve some block-commit, block-stream error messages, Markus Armbruster, 2020/12/10
- [PULL 02/13] qerror: Drop unused QERR_ macros, Markus Armbruster, 2020/12/10
- [PULL 10/13] qom: Improve {qom, device}-list-properties error messages, Markus Armbruster, 2020/12/10
- [PULL 01/13] Clean up includes, Markus Armbruster, 2020/12/10
- [PULL 06/13] ui: Improve a client_migrate_info error message, Markus Armbruster, 2020/12/10
- [PULL 11/13] Tweak a few "Parameter 'NAME' expects THING" error message, Markus Armbruster, 2020/12/10
- [PULL 03/13] qerror: Eliminate QERR_ macros used in just one place, Markus Armbruster, 2020/12/10
- [PULL 08/13] qga: Replace an unreachable error by abort(),
Markus Armbruster <=
- [PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs, Markus Armbruster, 2020/12/10
- [PULL 07/13] ui: Tweak a client_migrate_info error message, Markus Armbruster, 2020/12/10
- [PULL 09/13] qga: Tweak a guest-shutdown error message, Markus Armbruster, 2020/12/10
- [PULL 05/13] ui: Improve some set_passwd, expire_password error messages, Markus Armbruster, 2020/12/10
- Re: [PULL 00/13] Miscellaneous patches for 2020-12-10, Peter Maydell, 2020/12/10