qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 09/25] i386: move cpu dump out of helper.c into cpu-dump.


From: Richard Henderson
Subject: Re: [PATCH v11 09/25] i386: move cpu dump out of helper.c into cpu-dump.c
Date: Fri, 11 Dec 2020 10:13:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 12/11/20 2:31 AM, Claudio Fontana wrote:
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  target/i386/cpu.h       |   1 +
>  target/i386/cpu-dump.c  | 537 ++++++++++++++++++++++++++++++++++++++++
>  target/i386/helper.c    | 514 --------------------------------------
>  target/i386/meson.build |   1 +
>  4 files changed, 539 insertions(+), 514 deletions(-)
>  create mode 100644 target/i386/cpu-dump.c

There are a fair few "static const char * array[]" that should be "static const
char * const array[]", but is an existing error and this patch is pure code
movement.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]