Re: [PATCH v11 25/25] cpu: move do_unaligned_access to tcg_ops

[Richard Henderson]

On 12/11/20 2:31 AM, Claudio Fontana wrote:
> +++ b/include/hw/core/tcg-cpu-ops.h
> @@ -66,6 +66,13 @@ typedef struct TcgCpuOperations {
>                                    unsigned size, MMUAccessType access_type,
>                                    int mmu_idx, MemTxAttrs attrs,
>                                    MemTxResult response, uintptr_t retaddr);
> +    /**
> +     * @do_unaligned_access: Callback for unaligned access handling, if
> +     * the target defines #TARGET_ALIGNED_ONLY.
> +     */
> +    void (*do_unaligned_access)(CPUState *cpu, vaddr addr,
> +                                MMUAccessType access_type,
> +                                int mmu_idx, uintptr_t retaddr);

The comment is out of date.  TARGET_ALIGNED_ONLY is no longer relevant.  That
define only controls the default for MO_ALIGN.  The target can specify all
sorts of alignment apart from the default.

So let's lose everything after the "," and everything is ok.

Amusingly, I was this week considering how easy it would be to add alignment
checks to user-only.  But we're a fair way off from that now, so,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~