Re: [PATCH 19/20] block: Use GString instead of QString to build filenam

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/20] block: Use GString instead of QString to build filenam

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH 19/20] block: Use GString instead of QString to build filenames
Date:	Fri, 11 Dec 2020 21:47:32 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1

11.12.2020 20:11, Markus Armbruster wrote:

QString supports modifying its string, but it's quite limited: you can
only append.  Just one caller remains:
bdrv_parse_filename_strip_prefix() uses it just for building an
initial string.

Change it to do build the initial string with GString.  This is
another step towards making QString immutable.

Cc: Kevin Wolf<kwolf@redhat.com>
Cc: Max Reitz<mreitz@redhat.com>
Cc:qemu-block@nongnu.org
Signed-off-by: Markus Armbruster<armbru@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/20] Immutable QString, and also one JSON writer less, Markus Armbruster, 2020/12/11
- [PATCH 02/20] monitor: Use GString instead of QString for output buffer, Markus Armbruster, 2020/12/11
  - Re: [PATCH 02/20] monitor: Use GString instead of QString for output buffer, Dr. David Alan Gilbert, 2020/12/16
- [PATCH 04/20] qobject: Use GString instead of QString to accumulate JSON, Markus Armbruster, 2020/12/11
- [PATCH 14/20] qobject: Factor quoted_str() out of to_json(), Markus Armbruster, 2020/12/11
- [PATCH 08/20] qobject: Move internals to qobject-internal.h, Markus Armbruster, 2020/12/11
- [PATCH 05/20] qobject: Change qobject_to_json()'s value to GString, Markus Armbruster, 2020/12/11
- [PATCH 06/20] Revert "qstring: add qstring_free()", Markus Armbruster, 2020/12/11
- [PATCH 12/20] qobject: Drop qobject_get_try_str(), Markus Armbruster, 2020/12/11
- [PATCH 19/20] block: Use GString instead of QString to build filenames, Markus Armbruster, 2020/12/11
  - Re: [PATCH 19/20] block: Use GString instead of QString to build filenames, Vladimir Sementsov-Ogievskiy <=
- [PATCH 09/20] qmp: Fix tracing of non-string command IDs, Markus Armbruster, 2020/12/11
- [PATCH 03/20] qobject: Make qobject_to_json_pretty() take a pretty argument, Markus Armbruster, 2020/12/11
- [PATCH 07/20] hw/rdma: Replace QList by GQueue, Markus Armbruster, 2020/12/11
- [PATCH 10/20] block: Avoid qobject_get_try_str(), Markus Armbruster, 2020/12/11
  - Re: [PATCH 10/20] block: Avoid qobject_get_try_str(), Vladimir Sementsov-Ogievskiy, 2020/12/11
- [PATCH 15/20] qobject: Factor JSON writer out of qobject_to_json(), Markus Armbruster, 2020/12/11
- [PATCH 20/20] qobject: Make QString immutable, Markus Armbruster, 2020/12/11
- [PATCH 18/20] keyval: Use GString to accumulate value strings, Markus Armbruster, 2020/12/11
  - Re: [PATCH 18/20] keyval: Use GString to accumulate value strings, Paolo Bonzini, 2020/12/22
- [PATCH 01/20] hmp: Simplify how qmp_human_monitor_command() gets output, Markus Armbruster, 2020/12/11

Prev by Date: Re: [PATCH v5 6/7] tcg: implement JIT for iOS and Apple Silicon
Next by Date: Re: Some performance numbers for virtiofs, DAX and virtio-9p
Previous by thread: [PATCH 19/20] block: Use GString instead of QString to build filenames
Next by thread: [PATCH 09/20] qmp: Fix tracing of non-string command IDs
Index(es):
- Date
- Thread