Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

[Philippe Mathieu-Daudé]

On 12/11/20 7:51 PM, Claudio Fontana wrote:
> On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote:
>> On 12/11/20 7:22 PM, Richard Henderson wrote:
>>> On 12/11/20 12:15 PM, Claudio Fontana wrote:
>>>> Should I return this file to the original state (without the extra 
>>>> #includes that pretend it to be a standalone header file,
>>>> and call it
>>>>
>>>> tcg-cpu-ops.h.inc
>>>>
>>>> ?
>>>
>>> If this header can work with qemu/typedefs.h, then no, because the 
>>> circularity
>>> has been resolved.  Otherwise, yes.
>>
>> My editor got confused with TranslationBlock, which is why I asked
>> to include its declaration.
>>
>> Easier to forward-declare TranslationBlock in qemu/typedefs.h?
>>
>> Regards,
>>
>> Phil.
>>
> 
> Hello Philippe,
> 
> ok you propose to move the existing fwd declaration of TranslationBlock from 
> cpu.h to qemu/typedefs.h .

I'll let that answer to Richard =)

> 
> And what about #include "exec/memattrs.h"?
> 
> I assume you propose to put struct MemTxAttrs there as a fwd declaration too,
> 
> and this concludes our experiment here?

Well, there is no circular problem here, right?
(and Richard already reviewed patch #24 :P )

> 
> Thanks,
> 
> Claudio
>