[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 24/32] qdev: Make PropertyInfo.create return ObjectProperty*
From: |
Eduardo Habkost |
Subject: |
[PATCH v4 24/32] qdev: Make PropertyInfo.create return ObjectProperty* |
Date: |
Fri, 11 Dec 2020 17:05:21 -0500 |
Returning ObjectProperty* will be useful for new property
registration code that will add additional callbacks
to ObjectProperty after registering it.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Redone patch on top of additional changes in series v2
* Commit message reword
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
include/hw/qdev-properties.h | 3 ++-
hw/core/qdev-properties.c | 12 ++++++------
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index ab9c538ba4..aae882317a 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -34,7 +34,8 @@ struct PropertyInfo {
const QEnumLookup *enum_table;
int (*print)(Object *obj, Property *prop, char *dest, size_t len);
void (*set_default_value)(ObjectProperty *op, const Property *prop);
- void (*create)(ObjectClass *oc, const char *name, Property *prop);
+ ObjectProperty *(*create)(ObjectClass *oc, const char *name,
+ Property *prop);
ObjectPropertyAccessor *get;
ObjectPropertyAccessor *set;
ObjectPropertyRelease *release;
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 92f48ecbf2..3bb05e7d0d 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -821,13 +821,13 @@ const PropertyInfo qdev_prop_size = {
/* --- object link property --- */
-static void create_link_property(ObjectClass *oc, const char *name,
- Property *prop)
+static ObjectProperty *create_link_property(ObjectClass *oc, const char *name,
+ Property *prop)
{
- object_class_property_add_link(oc, name, prop->link_type,
- prop->offset,
- qdev_prop_allow_set_link_before_realize,
- OBJ_PROP_LINK_STRONG);
+ return object_class_property_add_link(oc, name, prop->link_type,
+ prop->offset,
+
qdev_prop_allow_set_link_before_realize,
+ OBJ_PROP_LINK_STRONG);
}
const PropertyInfo qdev_prop_link = {
--
2.28.0
- Re: [PATCH v4 19/32] qdev: Avoid using prop->name unnecessarily, (continued)
- [PATCH v4 15/32] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/12/11
- [PATCH v4 20/32] qdev: Add name parameter to qdev_class_add_property(), Eduardo Habkost, 2020/12/11
- [PATCH v4 21/32] qdev: Add name argument to PropertyInfo.create method, Eduardo Habkost, 2020/12/11
- [PATCH v4 22/32] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/12/11
- [PATCH v4 24/32] qdev: Make PropertyInfo.create return ObjectProperty*,
Eduardo Habkost <=
- [PATCH v4 25/32] qdev: Make qdev_class_add_property() more flexible, Eduardo Habkost, 2020/12/11
- [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/12/11