qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ui: add support for remote power control to VNC server


From: Gerd Hoffmann
Subject: Re: [PATCH] ui: add support for remote power control to VNC server
Date: Mon, 14 Dec 2020 12:05:07 +0100

On Fri, Dec 11, 2020 at 04:08:25PM +0000, Daniel P. Berrangé wrote:
> The "XVP" (Xen VNC Proxy) extension defines a mechanism for a VNC client
> to issue power control requests to trigger graceful shutdown, reboot, or
> hard reset.

Looks good.  Any other clients are supporting this?

> +            case VNC_XVP_ACTION_REBOOT:
> +                send_xvp_message(vs, VNC_XVP_CODE_FAIL);
> +                break;

> +            default:
> +                send_xvp_message(vs, VNC_XVP_CODE_FAIL);
> +                break;

Minor nit:

These two are identical, so you can drop the first.

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]