Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to c

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to c

From:	Yonggang Luo
Subject:	Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c
Date:	Mon, 14 Dec 2020 22:51:30 +0800

On Wed, Dec 9, 2020 at 6:09 AM Richard Henderson <richard.henderson@linaro.org> wrote:
>
> On 12/6/20 5:39 PM, Philippe Mathieu-Daudé wrote:
> > The rest of helper.c is TLB related. Extract the non TLB
> > specific functions to a new file, so we can rename helper.c
> > as tlb_helper.c in the next commit.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > Any better name? xxx_helper.c are usually TCG helpers.
>
> *shrug* perhaps cpu_common.c, no "helper" at all?
> Perhaps just move these bits to cpu.c?
>
>
> r~
>
Does these are general cpu bits or misp_cpu bits?

if only misp cpu related, prefer misp_cpu.c

or cpu.c under misp folder.

--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 07/19] target/mips: Include "exec/memattrs.h" in 'internal.h', (continued)
- [PATCH 08/19] target/mips: Extract cpu_supports*/cpu_set* translate.c, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 08/19] target/mips: Extract cpu_supports*/cpu_set* translate.c, Richard Henderson, 2020/12/08
- [PATCH 10/19] target/mips: Add !CONFIG_USER_ONLY comment after #endif, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 10/19] target/mips: Add !CONFIG_USER_ONLY comment after #endif, Richard Henderson, 2020/12/08
- [PATCH 09/19] target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 09/19] target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c, Richard Henderson, 2020/12/08
- [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c, Richard Henderson, 2020/12/08
    - Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c, Philippe Mathieu-Daudé, 2020/12/14
    - Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c, Yonggang Luo <=
    - Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c, Philippe Mathieu-Daudé, 2020/12/14
- [PATCH 13/19] target/mips: Fix code style for checkpatch.pl, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 13/19] target/mips: Fix code style for checkpatch.pl, Richard Henderson, 2020/12/08
- [PATCH 14/19] target/mips: Move mmu_init() functions to tlb_helper.c, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 14/19] target/mips: Move mmu_init() functions to tlb_helper.c, Richard Henderson, 2020/12/08
- [PATCH 12/19] target/mips: Rename helper.c as tlb_helper.c, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 12/19] target/mips: Rename helper.c as tlb_helper.c, Richard Henderson, 2020/12/08
- [PATCH 15/19] target/mips: Move cpu definitions, reset() and realize() to cpu.c, Philippe Mathieu-Daudé, 2020/12/06
  - Re: [PATCH 15/19] target/mips: Move cpu definitions, reset() and realize() to cpu.c, Richard Henderson, 2020/12/08
- [PATCH 16/19] target/mips: Inline cpu_mips_realize_env() in mips_cpu_realizefn(), Philippe Mathieu-Daudé, 2020/12/06

Prev by Date: Re: [PATCH v4 21/32] qdev: Add name argument to PropertyInfo.create method
Next by Date: Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c
Previous by thread: Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c
Next by thread: Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c
Index(es):
- Date
- Thread