[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 14/43] tcg: Make DisasContextBase.tb const
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v4 14/43] tcg: Make DisasContextBase.tb const |
Date: |
Mon, 14 Dec 2020 23:14:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/14/20 3:02 PM, Richard Henderson wrote:
> There is nothing within the translators that ought to be
> changing the TranslationBlock data, so make it const.
>
> This does not actually use the read-only copy of the
> data structure that exists within the rx region.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/exec/gen-icount.h | 4 ++--
> include/exec/translator.h | 2 +-
> include/tcg/tcg-op.h | 2 +-
> accel/tcg/translator.c | 4 ++--
> target/arm/translate-a64.c | 2 +-
> tcg/tcg-op.c | 2 +-
> 6 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH v4 05/43] tcg: Move tcg prologue pointer out of TCGContext, (continued)
- [PATCH v4 06/43] tcg: Move tcg epilogue pointer out of TCGContext, Richard Henderson, 2020/12/14
- [PATCH v4 07/43] tcg: Add in_code_gen_buffer, Richard Henderson, 2020/12/14
- [PATCH v4 08/43] tcg: Introduce tcg_splitwx_to_{rx,rw}, Richard Henderson, 2020/12/14
- [PATCH v4 11/43] tcg: Adjust tcg_out_label for const, Richard Henderson, 2020/12/14
- [PATCH v4 12/43] tcg: Adjust tcg_register_jit for const, Richard Henderson, 2020/12/14
- [PATCH v4 09/43] tcg: Adjust TCGLabel for const, Richard Henderson, 2020/12/14
- [PATCH v4 14/43] tcg: Make DisasContextBase.tb const, Richard Henderson, 2020/12/14
- Re: [PATCH v4 14/43] tcg: Make DisasContextBase.tb const,
Philippe Mathieu-Daudé <=
- [PATCH v4 10/43] tcg: Adjust tcg_out_call for const, Richard Henderson, 2020/12/14
- [PATCH v4 18/43] accel/tcg: Support split-wx for linux with memfd, Richard Henderson, 2020/12/14
- [PATCH v4 15/43] tcg: Make tb arg to synchronize_from_tb const, Richard Henderson, 2020/12/14
- [PATCH v4 20/43] tcg: Return the TB pointer from the rx region from exit_tb, Richard Henderson, 2020/12/14
- [PATCH v4 16/43] tcg: Use Error with alloc_code_gen_buffer, Richard Henderson, 2020/12/14
- [PATCH v4 13/43] tcg: Adjust tb_target_set_jmp_target for split-wx, Richard Henderson, 2020/12/14
- [PATCH v4 19/43] accel/tcg: Support split-wx for darwin/iOS with vm_remap, Richard Henderson, 2020/12/14
- [PATCH v4 17/43] tcg: Add --accel tcg,split-wx property, Richard Henderson, 2020/12/14