Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

[Gerd Hoffmann]

> > +    if (using_spice) {
> > +        /*
> > +         * When using spice allow the spice audio driver being picked
> > +         * as default.
> > +         *
> > +         * Temporary hack.  Using audio devices without explicit
> > +         * audiodev= property is already deprecated.  Same goes for
> > +         * the -soundhw switch.  Once this support gets finally
> > +         * removed we can also drop the concept of a default audio
> > +         * backend and this can go away.
> > +         */
> > +        driver = audio_driver_lookup("spice");
> > +        driver->can_be_default = 1;
> 
> fyi, one of my libvirt/QEMU guests now segfaults here.
> See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977301

Hmm, surely doesn't hurt to add a "if (driver)" check here.

I'm wondering though how you end up with spice being enabled
but spiceaudio driver not being available.  There is no separate
config switch so you should have both spice + spiceaudio or
none of them ...

take care,
  Gerd