[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/7] coreaudio: don't start playback in init routine
From: |
Gerd Hoffmann |
Subject: |
[PULL 2/7] coreaudio: don't start playback in init routine |
Date: |
Tue, 15 Dec 2020 14:48:21 +0100 |
From: Volker RĂ¼melin <vr_qemu@t-online.de>
Every emulated audio device has a way to enable audio playback. Don't
start playback until the guest enables the audio device to keep the
Core Audio device run state in sync with hw->enabled.
Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>
Signed-off-by: Volker RĂ¼melin <vr_qemu@t-online.de>
Message-id: 20201213130528.5863-2-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/coreaudio.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index 0ee85052c452..a5df95051461 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@ -584,17 +584,6 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct
audsettings *as,
return -1;
}
- /* start Playback */
- if (!isPlaying(core->outputDeviceID)) {
- status = AudioDeviceStart(core->outputDeviceID, core->ioprocid);
- if (status != kAudioHardwareNoError) {
- coreaudio_logerr2 (status, typ, "Could not start playback\n");
- AudioDeviceDestroyIOProcID(core->outputDeviceID, core->ioprocid);
- core->outputDeviceID = kAudioDeviceUnknown;
- return -1;
- }
- }
-
return 0;
}
--
2.27.0
- [PULL 0/7] Audio 20201215 patches, Gerd Hoffmann, 2020/12/15
- [PULL 1/7] coreaudio: rename misnamed variable fake_as, Gerd Hoffmann, 2020/12/15
- [PULL 4/7] audio: remove unused function audio_is_cleaning_up(), Gerd Hoffmann, 2020/12/15
- [PULL 5/7] cs4231: Get rid of empty property array, Gerd Hoffmann, 2020/12/15
- [PULL 3/7] coreaudio: always stop audio playback on shut down, Gerd Hoffmann, 2020/12/15
- [PULL 2/7] coreaudio: don't start playback in init routine,
Gerd Hoffmann <=
- [PULL 7/7] audio: add sanity check, Gerd Hoffmann, 2020/12/15
- [PULL 6/7] audio: Simplify audio_bug() removing old code, Gerd Hoffmann, 2020/12/15
- Re: [PULL 0/7] Audio 20201215 patches, Peter Maydell, 2020/12/15