[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/16] target/mips: Boring code reordering + add "translat
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 00/16] target/mips: Boring code reordering + add "translate.h" |
Date: |
Tue, 15 Dec 2020 20:00:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/15/20 3:24 PM, no-reply@patchew.org wrote:
> Patchew URL: 20201214183739.500368-1-f4bug@amsat.org/">https://patchew.org/QEMU/20201214183739.500368-1-f4bug@amsat.org/
>
>
> === OUTPUT BEGIN ===
> 1/16 Checking commit 02da9907b334 (target/mips: Inline cpu_state_reset() in
> mips_cpu_reset())
> 2/16 Checking commit a129631d782b (target/mips: Extract FPU helpers to
> 'fpu_helper.h')
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #42:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 193 lines checked
>
> Patch 2/16 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 3/16 Checking commit 8a5a0b7f9c26 (target/mips: Add !CONFIG_USER_ONLY comment
> after #endif)
> 4/16 Checking commit d10b7c71feb1 (target/mips: Remove consecutive
> CONFIG_USER_ONLY ifdefs)
> 5/16 Checking commit 051e87cd7a13 (target/mips: Extract common helpers from
> helper.c to common_helper.c)
> ERROR: space prohibited after that '&' (ctx:WxW)
> #41: FILE: target/mips/cpu.c:53:
> + cu = (v >> CP0St_CU0) & 0xf;
> ^
>
> ERROR: space prohibited after that '&' (ctx:WxW)
> #42: FILE: target/mips/cpu.c:54:
> + mx = (v >> CP0St_MX) & 0x1;
> ^
>
> ERROR: space prohibited after that '&' (ctx:WxW)
> #43: FILE: target/mips/cpu.c:55:
> + ksu = (v >> CP0St_KSU) & 0x3;
> ^
>
> ERROR: space prohibited after that '&' (ctx:WxW)
> #70: FILE: target/mips/cpu.c:82:
> + uint32_t ksux = (1 << CP0St_KX) & val;
> ^
>
> ERROR: space prohibited after that '&' (ctx:WxW)
> #78: FILE: target/mips/cpu.c:90:
> + mask &= ~(((1 << CP0St_SR) | (1 << CP0St_NMI)) & val);
> ^
>
> ERROR: space prohibited after that '&' (ctx:WxW)
> #105: FILE: target/mips/cpu.c:117:
> + mask &= ~((1 << CP0Ca_WP) & val);
> ^
>
> ERROR: space prohibited after that '&' (ctx:WxW)
> #110: FILE: target/mips/cpu.c:122:
> + if ((old ^ env->CP0_Cause) & (1 << CP0Ca_DC)) {
> ^
>
> ERROR: space prohibited after that '&' (ctx:WxW)
> #120: FILE: target/mips/cpu.c:132:
> + if ((old ^ env->CP0_Cause) & (1 << (CP0Ca_IP + i))) {
> ^
>
> total: 8 errors, 0 warnings, 433 lines checked
>
> Patch 5/16 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
All pre-existing issues (code moved).
- [PATCH v2 13/16] target/mips/translate: Add declarations for generic code, (continued)
- [PATCH v2 13/16] target/mips/translate: Add declarations for generic code, Philippe Mathieu-Daudé, 2020/12/14
- [PATCH v2 11/16] target/mips: Replace gen_exception_end(EXCP_RI) by gen_rsvd_instruction, Philippe Mathieu-Daudé, 2020/12/14
- [PATCH v2 12/16] target/mips/translate: Extract DisasContext structure, Philippe Mathieu-Daudé, 2020/12/14
- [PATCH v2 14/16] target/mips: Declare generic FPU functions in 'translate.h', Philippe Mathieu-Daudé, 2020/12/14
- [PATCH v2 16/16] target/mips: Only build TCG code when CONFIG_TCG is set, Philippe Mathieu-Daudé, 2020/12/14
- [PATCH v2 15/16] target/mips: Extract FPU specific definitions to translate.h, Philippe Mathieu-Daudé, 2020/12/14
- Re: [PATCH v2 00/16] target/mips: Boring code reordering + add "translate.h", no-reply, 2020/12/15
- Re: [PATCH v2 00/16] target/mips: Boring code reordering + add "translate.h",
Philippe Mathieu-Daudé <=