[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 20/24] target/mips: Use decode_ase_msa() generated from de
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2 20/24] target/mips: Use decode_ase_msa() generated from decodetree |
Date: |
Tue, 15 Dec 2020 17:15:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote:
> Now that we can decode the MSA ASE opcodes with decode_msa32(),
> use it and remove the unreachable code.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/translate.h | 12 ------------
> target/mips/mod-msa_translate.c | 29 +----------------------------
> target/mips/translate.c | 31 ++++++++++---------------------
> 3 files changed, 11 insertions(+), 61 deletions(-)
Need an update to the comment after function name change?
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v2 14/24] target/mips: Move msa_reset() to mod-msa_helper.c, (continued)
- [PATCH v2 14/24] target/mips: Move msa_reset() to mod-msa_helper.c, Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 15/24] target/mips: Extract MSA helpers from op_helper.c, Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 16/24] target/mips: Extract MSA helper definitions, Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 17/24] target/mips: Declare gen_msa/_branch() in 'translate.h', Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 18/24] target/mips: Extract MSA translation routines, Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 19/24] target/mips: Introduce decode tree bindings for MSA opcodes, Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 20/24] target/mips: Use decode_ase_msa() generated from decodetree, Philippe Mathieu-Daudé, 2020/12/15
- Re: [PATCH v2 20/24] target/mips: Use decode_ase_msa() generated from decodetree,
Richard Henderson <=
- [PATCH v2 21/24] target/mips: Extract LSA/DLSA translation generators, Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 22/24] target/mips: Introduce decodetree helpers for MSA LSA/DLSA opcodes, Philippe Mathieu-Daudé, 2020/12/15
- [PATCH v2 23/24] target/mips: Introduce decodetree helpers for Release6 LSA/DLSA opcodes, Philippe Mathieu-Daudé, 2020/12/15
- [RFC PATCH v2 24/24] target/mips/mod-msa: Pass TCGCond argument to gen_check_zero_element(), Philippe Mathieu-Daudé, 2020/12/15